Closed rahulmutt closed 5 years ago
Hi @rahulmutt
Apologies. There was a change to the codebase that effected your PR. Could you rebase your changes to current develop branch? Would love if you could include tests for your changes?
Thanks in advance.
Hi @cds-amal, I added a test and did a rebase. Let me know if you need anything else.
This resolves #198. I have tested this against one of my dapps and it works with an empty config when it didn't before.
Some notes:
I shifted the merging with
defaultOptions
to the earliest point so that the merged options is propogated correctly. It ensures that options will be in the desired format and downstream functions can safely assume it. If for some reason, the exact user-supplied options is required internally, I can store them in an additional field in theDrizzle
class.I had to add an extra check in
generateInitialContractState
because that can be called independently of the Drizzle constructor in case one is using a custom Redux store like I was.