Refactor/saga tests - Githubissues

trufflesuite / drizzle-legacy

Reactive Ethereum datastore for dapp UIs.

http://truffleframework.com/docs/drizzle/getting-started

MIT License

502 stars 129 forks source link

Refactor/saga tests #206

Closed cds-amal closed 5 years ago

cds-amal commented 5 years ago

This PR covers the potential issue described in #203 Update Saga tests.

adrianmcli commented 5 years ago

This would work, but do keep in mind the following:

eth-block-tracker-es5 was published more than a year ago
the block event has since been removed from the latest version of eth-block-tracker (I've messaged @kumavis for a rationale)

Otherwise, if it's working, then feel free to merge.

cds-amal commented 5 years ago

Drizzle is locked into the last version of eth-block-tracker-es5 and won't pull in the new package updates because the package.name changed to eth-block-tracker. I'm not keen on upgrading this dependency because we're moving on from polling but felt it best to follow the AP for the version we use.