search

trufflesuite / drizzle-legacy

Reactive Ethereum datastore for dapp UIs.
http://truffleframework.com/docs/drizzle/getting-started
MIT License
502 stars 129 forks source link

Some dependencies update #217

Closed MrRefactoring closed 5 years ago

adrianmcli commented 5 years ago

@cds-amal What's the status on reviewing this PR?

cds-amal commented 5 years ago

@MrRefactoring Thanks for this! It solves some Jest issues for us.

With your changes and introduction of .babelrc, jest.config.js no longer needs the transform rule and jest.transform.js can be removed. Is that correct? If it is can you also modify those files.

Thanks again!

MrRefactoring commented 5 years ago

Thanks for the review! I also wanted to update redux-saga and web3, but this causes some errors when testing. Can we review these errors together if I create another PR?

cds-amal commented 5 years ago

@MrRefactoring Thanks again for this update.

Please create a separate PR for redux-saga and I'll be happy to work with you on that. I feel that upgrading to redux-saga will need some care and more tests because redux-saga v1.0 introduced a number of breaking changes that have to be accounted for.

cds-amal commented 5 years ago

This looks good @MrRefactoring. I'll run integration tests against DRC and Drizzle box as a final confidence test.