search

trufflesuite / drizzle-legacy

Reactive Ethereum datastore for dapp UIs.
http://truffleframework.com/docs/drizzle/getting-started
MIT License
503 stars 128 forks source link

Redux saga updated #221

Closed MrRefactoring closed 5 years ago

MrRefactoring commented 5 years ago

Thanks for the link to changes in redux-saga. I was able to update redux-saga

cds-amal commented 5 years ago

Thank you for this @MrRefactoring! Updating the current tests to make them pass is a great start to upgrade to redux-saga v1.0.

I want to make sure we cover our bases on a major version upgrade. This includes reviewing/changing/approving the code as conforming to the new Saga's API, where necessary and addressing outstanding sagas issues like #171, #193 and others. I think it's probably best to identify the work up front so we can more easily handle/track the work. I will tag you when that's done.

0xTimepunk commented 5 years ago

ETA for this? :)

Thanks for the great work

adrianmcli commented 5 years ago

@MrRefactoring Thanks so much for making this PR! Unfortunately, we're in the process of moving over to a monorepo and this seems like a relatively simple to replicate PR for the new monorepo. Do you mind if we include this change after the move? Sorry for not addressing this PR earlier.

MrRefactoring commented 5 years ago

@adrianmcli, yes sure

MrRefactoring commented 5 years ago

Some of the changes moved #238 PR. It also contains changes that will lead to errors when using