If user denies access through MetaMask (6.6.0+) drizzle does not fail gracefully

trufflesuite / drizzle-legacy

Reactive Ethereum datastore for dapp UIs.

http://truffleframework.com/docs/drizzle/getting-started

MIT License

502 stars 129 forks source link

If user denies access through MetaMask (6.6.0+) drizzle does not fail gracefully #230

Closed dannycarrera closed 5 years ago

dannycarrera commented 5 years ago

With MetaMask 6.5.3, when user denied access, drizzleStatus was set to initialized but no accountBalances were available. (initializeWeb3 still returned a web3 instance)

Since MetaMask 6.6.0, multiple errors get thrown and no web3 instance is returned. Now there is no way to differentiate between no web3 provider and user denying access.

This also breaks the LoadingContainer of dependent project drizzle-react-components (it stays stuck at "Loading dapp..."

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been closed, but can be re-opened if further comments indicate that the problem persists. Feel free to tag maintainers if there is no reply to further comments.