search

trufflesuite / drizzle-legacy

Reactive Ethereum datastore for dapp UIs.
http://truffleframework.com/docs/drizzle/getting-started
MIT License
502 stars 129 forks source link

Fix/metamask 6.6.0 breaks access denied Rebased 1.4 #232

Closed dannycarrera closed 5 years ago

dannycarrera commented 5 years ago

Patch for #230

This change allows for the same behavior to continue since before the MetaMask 6.6.0 update, where drizzle still initializes web3 but no accounts are available. This is only a patch for v1.4 as #224 introduces the WEB3_USER_DENIED status.

Supersedes #231

eswarasai commented 5 years ago

@dannycarrera - Thanks a lot for reporting this issue and opening a PR. I'm exactly looking for this scenario to be handled within drizzle.

@cds-amal - Any status update on when can we expect this to be merged and released? Thanks!

cds-amal commented 5 years ago

Hi @eswarasai. Sorry for the late response. We're aware of this issue, but we're working on transitioning the way we structure our repos. We'll have more to say soon.

adrianmcli commented 5 years ago

@dannycarrera As we talked about, we're moving to a monorepo very very soon. So we'll unfortunately not be able to include this PR for now. However, once things have settled, we'd be happy to see your contributions on the new monorepo. Sorry for not addressing this PR earlier.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been closed, but can be re-opened if further comments indicate that the problem persists. Feel free to tag maintainers if there is no reply to further comments.