trufflesuite / drizzle-react-components-legacy

A set of useful components for common dapp UI elements.
96 stars 70 forks source link

Feature/hooked components #110

Closed dannycarrera closed 5 years ago

dannycarrera commented 5 years ago

drizzle-react offers access to react's new hooks API. Added AccountData, ContractData, and ContractForm components using the hooks API.

Added test-app-hooks, which is a copy of test-apps but using the new hooked components. (Note: in test-app-hooks/app/package.json, the version # will need to be updated once DRC with the new hooked components is released).

It was difficult to test the new components. I wasn't able to test using npm link, due to the restrictions on react hooks, only 1 react object can be available. I even tried linking from DRC/react to test-app-hooks/app/node_modules/react and though this solved the duplicate react error, then drizzle-react didn't work.

Eventually I ended up publishing a scoped version of drizzle-react-components, which allowed me to test. But this seems highly ineffective. Would appreciate any feedback on how to easily test DRC for future development.

Thanks!

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been closed, but can be re-opened if further comments indicate that the problem persists. Feel free to tag maintainers if there is no reply to further comments.