search

trufflesuite / drizzle-react-components-legacy

A set of useful components for common dapp UI elements.
96 stars 70 forks source link

Improve api for translateType for custom render in ContractForm #97

Closed honestbonsai closed 5 years ago

honestbonsai commented 5 years ago

I'm not a huge fan of the translateType interface in ContractForm's custom render, would be good to just send it down with this.inputs somehow.

Though I don't want to mutate this.inputs

adrianmcli commented 5 years ago

What exactly does translateType do? I don't see any documentation for it.

honestbonsai commented 5 years ago

With the custom rendered components for ContractForm, need to figure out a better way to send down the types.

See the current state: https://github.com/trufflesuite/drizzle-react-components/blob/develop/test-app/app/src/MyComponent.js#L14

Also see the default render version https://github.com/trufflesuite/drizzle-react-components/blob/develop/src/new-context-api/ContractForm.js#L61

honestbonsai commented 5 years ago

I have an idea of what to do for this.