trufflesuite / drizzle

Reactive Ethereum dapp UI suite

905 stars 235 forks source link

Fix/custom provider #15

Closed cds-amal closed 4 years ago

cds-amal commented 4 years ago

This PR fixes #14.

How to test

Note you will need 2 terminals

First terminal:

build out monorepo from the root project and start the ganache server yarn && yarn ganache

Second terminal:

deploy test contracts and start the test app

yarn ganache:deploy
cd ui-tests/custom-provider
yarn serve:ui

Verify

Use the browser of your choice with metamask installed, visit the test app and change SimpleStorage's StoredValue. The test is successful if you're able to change the value without MetaMask showing up.

OliveIT commented 4 years ago

Hi @cds-amal Webpack shows this warning when I try to build. ;)

WARNING in ./src/web3/web3Saga.js 85:18-35
"export 'WEB3_ERROR' (imported as 'Action') was not found in './constants'
 @ ./src/drizzleStatus/drizzleStatusSaga.js
 @ ./src/index.js

cds-amal commented 4 years ago

Thanks @OliveIT, thanks for testing and providing feedback! That issue is in another branch and will make it in as well.

cds-amal commented 4 years ago

@DiscRiskandBisque pointed out that customProvider should be an Object (a valid provider), not a url.

adrianmcli commented 4 years ago

Test works great, gonna take a look at the code and if nothing stands out let's merge!

adrianmcli commented 4 years ago

@cds-amal just the one question above, otherwise feel free to merge.