search

trufflesuite / drizzle

Reactive Ethereum dapp UI suite
905 stars 235 forks source link

@drizzle/store extending .npmignore #31

Closed MrRefactoring closed 4 years ago

adrianmcli commented 4 years ago

Thanks for the PR! I recall from a while back that we actually changed this to include the src for some reason. I can't remember what that reason is though, so maybe give us a bit of time to look into this. Thanks again!

adrianmcli commented 4 years ago

Found it! We need src to be published for React Native support: https://github.com/trufflesuite/drizzle-legacy/issues/130

But that being said, we could take out a bunch of the other stuff.

MrRefactoring commented 4 years ago

Found it! We need src to be published for React Native support: trufflesuite/drizzle-legacy#130

But that being said, we could take out a bunch of the other stuff.

This is a good use case. Remove src from npmignore

adrianmcli commented 4 years ago

lgtm, thanks!