search

trufflesuite / drizzle

Reactive Ethereum dapp UI suite
905 stars 235 forks source link

Index contracts by addresses rather than by name #38

Open julien51 opened 6 years ago

julien51 commented 6 years ago

Right now, Drizzle uses the contract names to identify them.... but I think it would be better to index them by address than by name because a given app could have multiple contracts with the same name.

marcogohi commented 6 years ago

Hi Julien,

yes, we have the same problem. We used the code you provided in a pullreq and works ok. I hope it is merged or considered ASAP.

Thank you!

soundyogi commented 5 years ago

Can we reference the PR here?

It seems to me that such a change would make sense since naming-conflicts are not a problem with contract addresses.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been closed, but can be re-opened if further comments indicate that the problem persists. Feel free to tag maintainers if there is no reply to further comments.

cds-amal commented 4 years ago

For 2.0 consideration