search

trufflesuite / ganache-cli-archive

Fast Ethereum RPC client for testing and development. See https://github.com/trufflesuite/ganache for current development.
https://www.trufflesuite.com/ganache
MIT License
3.36k stars 695 forks source link

getCompilers #213

Closed aakilfernandes closed 6 years ago

aakilfernandes commented 7 years ago

Expected Behavior

Return array of compilers

Current Behavior

Returns error

ReferenceError: cb is not defined
    at SolcSubprovider.handleRequest (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/subproviders/solc.js:20:7)
    at next (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/index.js:95:18)
    at VmSubprovider.handleRequest (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/subproviders/vm.js:40:12)
    at next (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/index.js:95:18)
    at GethDefaults.handleRequest (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/ethereumjs-testrpc/lib/subproviders/gethdefaults.js:17:12)
    at next (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/index.js:95:18)
    at FilterSubprovider.handleRequest (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/subproviders/filters.js:87:7)
    at next (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/index.js:95:18)
    at DelayedBlockFilter.handleRequest (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/ethereumjs-testrpc/lib/subproviders/delayedblockfilter.js:27:3)
    at next (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/index.js:95:18)
    at ReactiveBlockTracker.handleRequest (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/ethereumjs-testrpc/lib/subproviders/reactiveblocktracker.js:25:12)
    at next (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/index.js:95:18)
    at RequestFunnel.handleRequest (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/ethereumjs-testrpc/lib/subproviders/requestfunnel.js:32:12)
    at next (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/index.js:95:18)
    at Web3ProviderEngine._handleAsync (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/index.js:82:3)
    at /Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/node_modules/async/dist/async.js:1008:9
    at eachOfArrayLike (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/node_modules/async/dist/async.js:941:9)
    at eachOf (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/node_modules/async/dist/async.js:991:5)
    at _asyncMap (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/node_modules/async/dist/async.js:1006:5)
    at Object.map (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/node_modules/async/dist/async.js:996:16)
    at Timeout._onTimeout (/Users/aakilfernandes/projects/safemarket/solquester/node_modules/web3-provider-engine/index.js:63:13)
    at tryOnTimeout (timers.js:224:11)
    at Timer.listOnTimeout (timers.js:198:5)

Your Environment

MacOSx, ^3.0.2

tcoulter commented 7 years ago

Man, you're really poking (good) holes in TestRPC lately. I assume this should be an easy fix, as "solidity" is the only one. I'd guess there's not a test for this request.

aakilfernandes commented 7 years ago

Yup! I'm working on a fix. I've actually been working on a web3 alternative, hence all the testrpc poking =)

aakilfernandes commented 7 years ago

@tcoulter this should get fixed when https://github.com/MetaMask/provider-engine/pull/99 gets merged.

axic commented 7 years ago

Please avoid using eth_compile, it doesn't really belong to the RPC.

solc-js should be used directly in the web3.js alternative - gives much more flexibility too.

benjamincburns commented 6 years ago

At the moment we return ['solidity'] however this should be a null array as we no longer support eth_compileSolidity

mikeseese commented 6 years ago

Closing this in favor of https://github.com/trufflesuite/ganache-core/issues/139