Filtering with checksum addresses

carver commented 6 years ago

I asked about this on gitter: [x]

Expected Behavior

A deployed contract is emitting logs.
A filter is created that specifies a from address using the checksum address format from EIP-55
The events are triggered in new blocks
A client requests new entries tied to the created filter
The logs are returned

Current Behavior

Everything as expected, except the last step: no logs are returned.

Note that if the lower-case address is used in the filter instead, that logs are returned. So all other steps appear to be configured correctly.

Possible Solution

Force addresses to lower-case in the filter before searching? (optionally, verifying checksums)

Steps to Reproduce (for bugs)

I'm cross-posting from a web3py bug report, which includes source: https://github.com/ethereum/web3.py/issues/674

Given the simplicity of the workaround, it seems that the problem should be easy to reproduce.

Context

Without this fix, ganache filters will appear broken in the next stable release of web3py, which is likely within a week or two. All other nodes appear to work as expected.

Your Environment

I'll ask the original posters on the web3.py issue to fill in this info:

Version used:
Version of Truffle/Remix/Other tools used:
NodeJS Version: [ ] 6.x, [ ] 7.x (unsupported), [ ] 8.x, [ ] 9.x
Operating System and version (include distro if Linux):
Link to your project or repro gist:
Commit hash to use with above link for reproduction:
I intend to submit a pull request to fix this issue: [ ]

jordanjambazov commented 6 years ago

I confirm the issue was reproducible 24 days ago with latest version of Docker Ganache-CLI: v6.1.0-beta.2

pipermerriam commented 6 years ago

Ping, any chance this can be fixed soon? We get a steady stream of people encountering this error over in https://github.com/ethereum/web3.py

5hanth commented 6 years ago

"Force addresses to lower-case in the filter before searching" is accepted solution to fix this for now?

boolafish commented 6 years ago

Ping! we would really like to see this solved as well

lbrth commented 6 years ago

Does anyone know when the issue will be solved ?

gakonst commented 6 years ago

+1 ping, would love if this was solved!

llxxee commented 6 years ago

exact same issue with Ganache CLI v6.0.3 (ganache-core: 2.0.2)

5hanth commented 6 years ago

I can give a PR if I may know what excatly is the agreed solution to fix this. Force lowercase addresses?

lbrth commented 6 years ago

@5hanth Force lowercase addresses works for me but by default with the current version of web3.py you will raise an exception : InvalidAddress("Address has an invalid EIP checksum", value). To fix that we have to edit the current version of web3.py, or get correct patch. Please see the issue #826 (by the way, thank's to @gakonst) to see how it's work and how to fix.

carver commented 6 years ago

I can give a PR if I may know what excatly is the agreed solution to fix this. Force lowercase addresses?

Yes, since it seems that ganache expects lower-case hex data internally, then it should force all incoming hex to lower-case (addresses, filter parameters, block hashes, etc)

To fix that we have to edit the current version of web3.py, or get correct patch.

json-rpc clients should be able to send hex-encoded binary in any case: upper, lower, or mixed. So changing how web3.py works is not a good solution here. (Even if web3.py forced all hex to lower case, then the same change would have to happen in all other clients, and even hand-written json-rpc calls)

robinagist commented 6 years ago

same issue here. straightout rejection by web3.py on addresses.

edevil commented 6 years ago

Sad that web3.py and Ganache cannot interoperate correctly. They were my goto tools for ethereum development.