search

trufflesuite / ganache

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.
https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_
MIT License
2.62k stars 678 forks source link

refactor: remove support for deprecated test networks #3732

Closed jeffsmale90 closed 2 years ago

jeffsmale90 commented 2 years ago

Removes native support for deprecated testnets: Kovan, Ropsten, and Rinkeby.

Fixes #3706

jeffsmale90 commented 2 years ago

I was unsure about the conventional commit, but after reading a little (including this SO https://stackoverflow.com/questions/48075169/semantic-commit-type-when-remove-something), I figured refactor! was probs the best.

Happy to hear alternatives however.

davidmurdoch commented 2 years ago

The "!" indicates a breaking change. Which this change is not because the feature being removed is not being removed by us.

davidmurdoch commented 2 years ago

And I agree with Micaiah on agreeing with myself on removing the ! from the title.

jeffsmale90 commented 2 years ago

Approving, be a rebel and slam the green button

At least someone appreciates my work :P

I've fixed the indentation, and removed the ! in the title.