search

trufflesuite / ganache

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.
https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_
MIT License
2.62k stars 678 forks source link

consider removing `eth_subscribe` from tests #3754

Open MicaiahReid opened 2 years ago

MicaiahReid commented 2 years ago

Since eth_subscribe/await message stuff is not needed since we default to eager mode should we keep doing it in our tests? :thinking: I'm torn because it is technically correct... buuuuttt the way we do it isn't 100% correct (since maybe something else also subscribed to a some different thing, and then the once("message") might not be the message we were waiting for)

_Originally posted by @davidmurdoch in https://github.com/trufflesuite/ganache/pull/3321#discussion_r967472508_

davidmurdoch commented 2 years ago

I think we should do it. If we ever want to run all tests in both modes this would change would suck, but I don't think all tests are consistent enough to do it in either mode as is anyway.