trufflesuite / ganache

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.
https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_
MIT License
2.62k stars 678 forks source link

Ganache should update its CI dependencies #3835

Open cds-amal opened 1 year ago

cds-amal commented 1 year ago

Ganache has some deprecation warnings in CI.

See this run,,, click me. I submitted a PR to update most of the issues, but these two remaining ones touch on CI logic. The Ubuntu one may be easy as it is already excluded... but I could be misunderstanding things.

davidmurdoch commented 1 year ago

Re set-output, we don't us it directly. I wonder where it is coming from.

Re ubuntu 18.04. We have a PR to fix it here https://github.com/trufflesuite/ganache/pull/3405. It was previously blocked by Node v12 support.

MicaiahReid commented 1 year ago

@davidmurdoch we do use set-output for the new docker action for our releases. I didn't realize it was deprecated. Seems like it should be an easy fix to remove it.

cds-amal commented 1 year ago

https://github.com/trufflesuite/ganache/blob/develop/.github/workflows/release.yml#L57 https://github.com/trufflesuite/ganache/blob/develop/.github/workflows/release.yml#L131

davidmurdoch commented 1 year ago

Ah, I'm working on branch that hasn't rebased to include the docker yaml stuff. Thanks for the correct!