search

trufflesuite / ganache

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.
https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_
MIT License
2.62k stars 678 forks source link

Detach mode could have simplified file management #3965

Open jeffsmale90 opened 1 year ago

jeffsmale90 commented 1 year ago

Once the minimum supported version of node is >= 14.14, removal of files could be simplified in detach mode.

detach.ts currently uses a mixture of unlink and rmdir to remove wanted and unwanted files from the instances directory. This could be replaced by fsPromises.rm, utilising the recursive argument.

https://nodejs.org/api/fs.html#fspromisesrmpath-options