make `BlockHeader`'s `miner` field an `Address`

trufflesuite / ganache

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.

https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_

MIT License

2.62k stars 678 forks source link

make `BlockHeader`'s `miner` field an `Address` #3994

Open MicaiahReid opened 1 year ago

MicaiahReid commented 1 year ago

It's currently type Data and we are always doing new Address(header.miner.toBuffer()). I think we can safely switch it to Address

sj00coder commented 1 year ago

Hey @MicaiahReid, Can I work on this issue?

davidmurdoch commented 1 year ago

@sj00coder, go for it!

sj00coder commented 1 year ago

Hey @MicaiahReid , I raised the PR. Please have a look.

MicaiahReid commented 1 year ago

Hey @sj00coder, thanks for the PR! I'm no longer working on Ganache, but I'm sure @davidmurdoch will take a look