chore: remove `Promise.allSettled` shim

trufflesuite / ganache

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.

https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_

MIT License

2.62k stars 678 forks source link

chore: remove `Promise.allSettled` shim #4003

Closed tenthirtyone closed 1 year ago

tenthirtyone commented 1 year ago

This was TODO'd to be removed if we bumped typescript to 4.2.3+

davidmurdoch commented 1 year ago

Looks like it doesn't work in Node v12.0.0. Let's wait on this until after the-merge is in

davidmurdoch commented 1 year ago

@tenthirtyone let's merge this one after the merge is released (which should be later today).

tenthirtyone commented 1 year ago

This all looks good to me. If you merge develop it'll kill off the node12 builds partying_face

@jeffsmale90 - should have been taken care of in https://github.com/trufflesuite/ganache/pull/4003/commits/6268b367cfdb4b3e86b6a37267d3a86b59c824c0

gitpoap-bot[bot] commented 1 year ago

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ganache Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.