enable broken version check test for all OS except mac; or figure out why mac isn't working

trufflesuite / ganache

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.

https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_

MIT License

2.62k stars 676 forks source link

enable broken version check test for all OS except mac; or figure out why mac isn't working #4155

Open tenthirtyone opened 1 year ago

tenthirtyone commented 1 year ago

    I assume this is something to do with the test depending on 1ms elapsing ? I don't understand why it's mac specific though.

It'd be nice if we could inject a time provider or something, so that we didn't have that reliance.

Either way, what's the action here? Shall we fix the test, or remove it?

_Originally posted by @jeffsmale90 in https://github.com/trufflesuite/ganache/pull/3285#discussion_r1035511204_

jeffsmale90 commented 1 year ago

We could make the test os dependent (not run on Mac) and make an issue for it

MicaiahReid commented 1 year ago

Just so we have a link to the actual test: https://github.com/trufflesuite/ganache/pull/3285/files#diff-55908782ffd08630e6a6f0badb9c26ef38d4eb07fba2cf5b21aca7f2bc839914R660