search

trufflesuite / truffle-compile

Compiler helper and artifact manager
22 stars 46 forks source link

solc 0.4.19 #39

Closed denys-popov closed 6 years ago

denys-popov commented 6 years ago

new version of solc

denys-popov commented 6 years ago

Strange I run it on https://travis-ci.org/purblind/truffle-compile/jobs/318270495 and everything fine.

cedricwalter commented 6 years ago

hi what the status on this PR?

gnidan commented 6 years ago

Planning to get this upgrade out in a patch release next week. Thanks for the contribution here!

@purblind would you mind pulling changes upstream from develop on your branch? I think you are missing a change that I suspect is causing the build failure, and would just like to validate that hypothesis.

Thanks!

denys-popov commented 6 years ago

@gnidan fixed :)

gnidan commented 6 years ago

Travis is still failing on the AST test. I'll have to investigate further.

I prefer the scientific method when my hypotheses are correct -___-

gnidan commented 6 years ago

Caught it, problem with outputSelection. Merging!

Thanks for the PR!