search

trufflesuite / truffle-hdwallet-provider

HD Wallet-enabled Web3 provider
MIT License
401 stars 167 forks source link

mnemonic not checked #1

Open ajunge opened 7 years ago

ajunge commented 7 years ago

mnemonic not checked. Should be validated like this:

if (!bip39.validateMnemonic(mnemonic)) {
 return "error"
}
okwme commented 6 years ago

i've been pushing to rinkeby with mnemonic = undefined on accident there's actually a lot of ether in the wallet that gets unlocked 0x959fd7ef9089b7142b6b908dc3a8af7aa8ff0fa1

piavgh commented 5 years ago

Is this issue fixed? I passed "undefined" in side

const provider = new HDWalletProvider(
    undefined,
    'https://rinkeby.infura.io/v3/ebaf1785cc1b4f319e0ff07f26cadae8'
);

and it still deploys without problem.

The list of accounts returned from web3.eth.getAccounts() is

0x959FD7Ef9089B7142B6B908Dc3A8af7Aa8ff0FA1