trufflesuite / truffle-hdwallet-provider

HD Wallet-enabled Web3 provider
MIT License
400 stars 167 forks source link

Document hidden param for multiple addresses #32

Closed micahalcorn closed 5 years ago

micahalcorn commented 6 years ago

This updates the parameters documentation to include num_addresses. The prior instruction caused some confusion here.

emkman commented 6 years ago

Agree this update is much needed as people are being limited by misleading docs when the code has great new functionality in it. You should also remove this note in the paragraph preceeding your change:

Currently, the HDWalletProvider manages only one address at a time, but it can be easily upgraded to manage (i.e., "unlock") multiple addresses.

Thanks!

micahalcorn commented 6 years ago

Good call @emkman 👍 I've added a commit.

benjamincburns commented 5 years ago

Thanks for this @micahalcorn! We've already included this via another PR.