search

trufflesuite / truffle-hdwallet-provider

HD Wallet-enabled Web3 provider
MIT License
400 stars 167 forks source link

Allow bip39 `mnemonicToSeed` password field to be set #50

Closed zrubenst closed 5 years ago

zrubenst commented 6 years ago

bip39 provides the function mnemonicToSeed(mnemonic[, password]), however you aren't allowing passwords to be used. Please allow passwords to be used. Thanks.

bejavu commented 6 years ago

added an option to set password to mnemonic + the option to add multiple mnemonics:

60

benjamincburns commented 5 years ago

Hi @zrubenst, thanks for contributing this. Unfortunately I'm uncertain as to the specific utility of the addition. If we accept the change I want to make sure that it's well documented so that new users don't get confused.

I'm in the process of moving this module over to the trufflesuite/truffle monorepo, and I'm trying to capture/accept all of the straightforward PRs possible prior to making the switch. Also bear in mind that once this module is moved over I intend to rewrite it to be a much smaller (w.r.t. code size) and more minimalistic, as it's quite heavyweight at the moment. This may mean that we move some concerns outside of this module, into other modules.

Can you do me a favor and open an issue over here and describe the problem you're trying to solve with this change? The change here is small, so if this addition solves a specific problem we'll be sure to add it quickly.