search

trufflesuite / truffle-migrate

On-chain migrations management
17 stars 17 forks source link

Await the migration really is done #27

Closed jtakalai closed 4 years ago

jtakalai commented 6 years ago

What happens currently: (async) migration awaits for things like smart contract calls, fails, but still the finish() function is called an migration is marked as successful in the blockchain. That's just bad.

cgewecke commented 6 years ago

@jtakalai If you have a chance could you sync your fork and branch to next?

git checkout next
git merge develop
git checkout patch-2
git merge next
cgewecke commented 6 years ago

@jtakalai Actually - don't worry about that - let me double-check the debugger tests see if there a way to fix this build.

cgewecke commented 6 years ago

@jtakalai It looks the debugger tests are catching a problem with the solution you've proposed. Could you try to verify that it will run a migration formatted the way the debugger's tests are here?

jtakalai commented 4 years ago

outdated, probably fixed by now