Add integration tests for `truffle develop`

[gnidan]

Issue

Ahhh! truffle develop was broken on next! This shouldn't happen!

Requirements

The scenario tests should at least exercise truffle develop a little bit. Just so it doesn't get totally broken.

There's potentially more work in engineering a testing strategy for interacting with our various REPLs, but this should probably be excluded from the scope of this work.

The scope of work for this issue is basically to ensure that this doesn't happen:

TypeError: Cannot read property 'accounts' of undefined
    at Object.run (/.../truffle/packages/truffle-core/lib/commands/develop.js:60:37)
    at Command.run (/.../truffle/packages/truffle-core/lib/command.js:103:20)
    at Object.<anonymous> (/.../truffle/packages/truffle-core/cli.js:40:9)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3
Truffle (unbundled) (core: 5.0.0-beta.1)
Solidity v0.4.25 (solc-js)
Node v8.11.3

[vibern0]

Hi, I think I can do this, but I don't know exactly where to start. Can you please give me a hint? I ran the npm run test and I was looking into files.

[Meabo]

Same here, I was looking for an entry point @gnidan, thanks

[gnidan]

@obernardovieira @Meabo thanks for the interest in this!

The basic task here is to write a scenario test in packages/truffle/test/scenarios, to invoke truffle develop and run commands inside it.

For a more sophisticated approach, there might be something to the idea of modifying packages/truffle/test/scenarios/commandrunner.js script to run all scenario tests in various ways:

• via truffle <command> on the shell
• via truffle console connecting to external Ganache, external Geth, etc.?
• via truffle develop. But this would likely require consideration along the lines described in #1336, so there could be parallel CI jobs, for instance. Probably don't want to pursue this approach now, unless anyone has ideas for how this might get engineered.

Most immediately, the requirements are that there should be automated tests for truffle develop, testing a few basic happy/sad paths around at least these commands:

• version
• compile
• migrate
• test

I opened this issue just to address the problem of catching obvious breakages at merge-time instead of release-time.

[vibern0]

Thanks @gnidan for quick response. I have one doubt, CommandRunner.run is running commands but actually waiting them to end at some point. Since I want to run the truffle develop and then the other commands inside, is there any example I can follow or do I need to build this kind of thing from scratch?

[gnidan]

From scratch, I'm afraid. :/

[gnidan]

Oh, a naïve solution might be to wait for the specific stdout output truffle(develop)> to know when the prompt is available.

A less naïve solution would be to use IPC messaging, since truffle develop works as part of an IPC cluster. But this sounds like a lot to implement.

[vibern0]

Ok, doesn't seem easy at first sight, but I will have a try and reply asap. Thanks so far.

[gnidan]

Thank you!

[stale[bot]]

Thank you for raising this issue! It has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you would like to keep this issue open, please respond with information about the current state of this problem.

[eggplantzzz]

Not stale

[vibern0]

Unfortunately, I did not have time to do much. Shame that it was 2 months ago :disappointed: sorry guys.

[stale[bot]]

Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can.

[eggplantzzz]

@obernardovieira No problem, it will get done eventually :) It does not seem trivial.

[stale[bot]]

Thank you for raising this issue! It has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you would like to keep this issue open, please respond with information about the current state of this problem.

[stale[bot]]

There has been no new activity on this issue since it was marked as stale 7 days ago, so it is being automatically closed. If you'd like help with this or a different problem, please open a new issue. Thanks!

[stale[bot]]

Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can.

[CruzMolina]

Assigning to myself to keep open 😠