Migration assumes behavior of `--reset` without `--reset` flag

trufflesuite / truffle

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.

https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_

MIT License

14.02k stars 2.31k forks source link

Migration assumes behavior of `--reset` without `--reset` flag #5879

Open cliffoo opened 1 year ago

cliffoo commented 1 year ago

Reproduction steps

Start ganache.
Point truffle config to ganache.
Run migrate, it migrates.
Run migrate again. It should say network is up-to-date, but no it migrates again.

Environment

Operating System: Ubuntu 22.10
Ethereum client: Ganache 7.5.0
Truffle version (truffle version): 5.7.5
node version (node --version): 18.12.0
npm version (npm --version): 8.19.2

cliffoo commented 1 year ago

Potentially related to timestamp handling on contract source files. @eggplantzzz was on macOS and couldn't reproduce it, but @cds-amal did on both linux and macOS machines.

eggplantzzz commented 1 year ago

We should consider adding another way to keep track of which migrations have been run (something that is not Migrations.sol).