Indicate Node.js supported versions

trufflesuite / truffle

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.

https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_

MIT License

14.02k stars 2.31k forks source link

Indicate Node.js supported versions #6180

Closed legobeat closed 1 year ago

legobeat commented 1 year ago

PR description

Add engines.node to indicate supported Node.js version range
- Assuming minimum 16 since #6169 removed v14 from CI
Add .nvmrc set to lts/*
ci: Read version for yarncheck job from .nvmrc instead of using harcoded vesion

Testing instructions

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if documentation updates are required.

Breaking changes and new features

[x] I have added any needed breaking-change and new-feature labels for the appropriate packages.

haltman-at commented 1 year ago

Hm, do we want to set .nvmrc to lts/*? That's what it is now, but we've often lagged behind a bit.

legobeat commented 1 year ago

How about pinning to lts as of now, 18?

I guess it's mostly a matter of if you want future upgrades to be explicit or not.

haltman-at commented 1 year ago

Oh, well right now we're still supporting 16, so...?

legobeat commented 1 year ago

@haltman-at Note that the value in .nvmrc does not affect which version unit tests are being run in (which still includes 16) - only the yarncheck job is being changed to use .nvmrc here.