search

trufflesuite / truffle

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.
https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_
MIT License
14.03k stars 2.31k forks source link

deps: dedupe and lockbump ethers, ethereumjs, web3 #6192

Closed legobeat closed 10 months ago

legobeat commented 10 months ago

PR description

Dedupes and performs lockfile bumps of packages in the ethers, ethereumjs, and web3 families.

Note that this implies a major upgrade of transitive bn.js from v4 to v5.

Related

Testing instructions

Documentation

Breaking changes and new features

legobeat commented 10 months ago

@haltman-at : Yup! This doesn't do any semver-violating changes so nothing changed there.

FWIW there is sill ethers@^4 used in contracts and interface-adapter while the rest of the usage looks to all be v5.

legobeat commented 10 months ago

FYI just added on 4372ee3706aefb783f1989b139f8d3c32e94a589 which dedupes the remaining @ethersproject/^5 duplicates.

haltman-at commented 10 months ago

Yeah, I remember there being a reason why contract is still on v4, although I don't remember offhand what it is. OTOH interface-adapter I didn't know about, I wonder if there's a reason for that one?