search

trufflesuite / trufflesuite.com

Trufflesuite website source ✨
https://trufflesuite.com
181 stars 421 forks source link

sitemap.xml not valid / generating correctly #1168

Open kevinbluer opened 2 years ago

kevinbluer commented 2 years ago

Spotted when attempting to import the sitemap.xml into the Google Search Console. It's likely the issue arrises during the mkdocs build step. Also worth confirming how it looks when built locally vs the build generated by the Github Action (example).

michaeljohnbennett commented 2 years ago

checking locally for mkdocs build and this is happening as well. Will need to search over the mkdocs issues for some pointers/ideas

jlazoff commented 2 years ago

Hi @kevinbluer @michaeljohnbennett, Here is a small outline of the sitemap and URL structures that need to be in sync: https://github.com/trufflesuite/trufflesuite.com/pull/1177#issuecomment-1074192436

Great work!

cds-amal commented 2 years ago

cc: @kevinbluer , should this be closed?

jlazoff commented 2 years ago

cc: @kevinbluer , should this be closed?

The sitemap looks much better! I don't see the index.html pages, but want to get confirmation that its 100% resolved. cc @kevinbluer @davidmurdoch

davidmurdoch commented 2 years ago

@jlazoff

Urls ending with "/" are now canonical and we redirect (302, currently, to make sure things are working correctly) urls ending in *.html* to $1/$2 using a simple cloudflare page rule.

We haven't yet updated internal *.html links to point to their new canonical locations.