search

trufflesuite / trufflesuite.github.io

Staging Repo of Build Artifacts for Truffle Suite. Find the source at https://github.com/trufflesuite/trufflesuite.com
https://www.trufflesuite.com
34 stars 161 forks source link

Fix require() conditions #137

Closed teixas closed 6 years ago

teixas commented 7 years ago

Didn't notice that there is a related PR #123. But conditions used there on require() are wrong.

bmmpxf commented 6 years ago

Hi @teixas . Sorry it's taken so long to get back to you on this PR. I think a lot of things have changed since this was first suggested. Also, it looks like there is more going on here that the title doesn't allude to.

I'm going to close this, but if you'd like to reopen it, that's fine, just please add comments as to what is going on (and perhaps squash your commits). We'll be happy to look at this more closely (and quickly this time). Thanks!

(Also, please submit only changes to the .md files. We'll take care of the build process.)