search

trufflesuite / uws-js-unofficial

μWebSockets for Node.js back-ends :metal:
Apache License 2.0
4 stars 6 forks source link

Fallback error handling is sketchy #7

Open davidmurdoch opened 3 years ago

davidmurdoch commented 3 years ago

See https://github.com/trufflesuite/uws-js-unofficial/blob/d91c4d02be0b1eafd156aa4b85786f5a1a21e181/src/fallback/websocket.ts#L22-L32

What cases are we missing? How can we figure it out to align them better?

davidmurdoch commented 3 years ago

Also of interest is this comment in uWebsockets about why the close code is 1006 instead of 1009.