trufi-association / hamburg-bike-app

ITS Moin Hack Bike Planning App
3 stars 1 forks source link

BUG: No difference between more bike/less bike etc. #84

Open ZihRah opened 3 years ago

ZihRah commented 3 years ago

The app shows the same results when you search a route with “Mehr Rad” or “Beides” or “Mehr OPNV” option.

https://drive.google.com/file/d/1lyuvtP2nEHgAwWrP-fyuSpUiopmLl_RZ/view?usp=sharing

Bildschirmfoto 2021-09-22 um 19 53 05

Bildschirmfoto 2021-09-22 um 19 53 35

Bildschirmfoto 2021-09-22 um 19 54 02

ValorNaram commented 3 years ago

Wrong assignment.

JoeRossberg commented 3 years ago

I retested it today with several new request and bug is still there ( persistent ).

SamuelRioTz commented 3 years ago

@ValorNaram the issues is also present on the OTP-ui Screen Shot 2021-09-29 at 20 42 32

SamuelRioTz commented 3 years ago

@ValorNaram maybe the solution could be make the presets more different Screen Shot 2021-09-29 at 20 50 41

ValorNaram commented 3 years ago

@SamuelRioTz We did what you mentioned before and I also tested it on my own. Maybe the following settings are better.

More bike bikeBoardCost=2000

More ÖPNV bikeBoardCost=400

If it is still not useable we need to combine the bikeBoardCost with the following:

0% 0 100% 1

Quick: triangleTimeFactor Flat: triangleSlopeFactor Bike Friendly: triangleSafetyFactor

Flat: 100% https://api.trufi.app/otp/routers/default/plan?fromPlace=53.61857936489517,9.986572265624998&toPlace=53.60676632634897,10.073089599609375&time=7:46pm&date=09-13-2021&mode=TRANSIT,BICYCLE&maxWalkDistance=4828.032&arriveBy=false&wheelchair=false&optimize=TRIANGLE&triangleTimeFactor=0&triangleSlopeFactor=1&triangleSafetyFactor=0&debugItineraryFilter=false&locale=en

Quick 100% https://api.trufi.app/otp/routers/default/plan?fromPlace=53.61857936489517,9.986572265624998&toPlace=53.60676632634897,10.073089599609375&time=7:46pm&date=09-13-2021&mode=TRANSIT,BICYCLE&maxWalkDistance=4828.032&arriveBy=false&wheelchair=false&optimize=TRIANGLE&triangleTimeFactor=1&triangleSlopeFactor=0&triangleSafetyFactor=0&debugItineraryFilter=false&locale=en

Quick 48% Flat 52% https://api.trufi.app/otp/routers/default/plan?fromPlace=53.61857936489517,9.986572265624998&toPlace=53.60676632634897,10.073089599609375&time=7:46pm&date=09-13-2021&mode=TRANSIT,BICYCLE&maxWalkDistance=4828.032&arriveBy=false&wheelchair=false&optimize=TRIANGLE&triangleTimeFactor=0.48148148148148145&triangleSlopeFactor=0.5185185185185184&triangleSafetyFactor=2.220446049250313e-16&debugItineraryFilter=false&locale=en

https://api.trufi.app/otp/routers/default/plan?fromPlace=53.61857936489517,9.986572265624998&toPlace=53.60676632634897,10.073089599609375&time=7:46pm&date=09-13-2021&mode=TRANSIT,BICYCLE&maxWalkDistance=4828.032&arriveBy=false&wheelchair=false&optimize=TRIANGLE&triangleTimeFactor=0.06172839506172839&triangleSlopeFactor=0.29003652401034596&triangleSafetyFactor=0.6482350809279256&debugItineraryFilter=false&locale=en

ZihRah commented 3 years ago

@ValorNaram We want to raise the difference between more bike, more public transport and both. But to do so Samuel need new parameters for the triangle. Could you please take care of it.

ZihRah commented 3 years ago

There is still no difference:

Bildschirmfoto 2021-10-09 um 17 25 38 Bildschirmfoto 2021-10-09 um 17 25 54 Bildschirmfoto 2021-10-09 um 17 26 07

ValorNaram commented 3 years ago

Ok, will work on that.

ValorNaram commented 3 years ago

Ok, we switch back to the triangle which was also my first idea.

Send the following query string parameters extra when the user wishes:

More bike

triangleSafetyFactor=1
triangleTimeFactor=0
triangleSlopeFactor=0
optimize=TRIANGLE

More ÖPNV

triangleSafetyFactor=0
triangleTimeFactor=1
triangleSlopeFactor=0
optimize=TRIANGLE

PS: In my previous proposal I oversaw the parameter optimize=TRIANGLE which activates the other parameters so they can be set. This is the reason why my first proposal did not work.

GustavoTCh commented 3 years ago

Simulator Screen Shot - iPhone 12 Pro Max - 2021-10-11 at 10 06 23 Simulator Screen Shot - iPhone 12 Pro Max - 2021-10-11 at 10 06 10

ValorNaram commented 3 years ago

Send the following query string parameters extra when the user wishes:

More bike

triangleSafetyFactor=1
triangleTimeFactor=0
triangleSlopeFactor=0
optimize=TRIANGLE
searchWindow=578

searchWindow is new.

More ÖPNV (unchanged)

triangleSafetyFactor=0
triangleTimeFactor=1
triangleSlopeFactor=0
optimize=TRIANGLE
ValorNaram commented 3 years ago

More bike

image

More ÖPNV

image