optimize decompilation - Githubissues

truj / midica

A Music programming language. Translates source code into MIDI. Includes a player. Supports MIDI-Karaoke. Includes a MIDI analyzer.

https://www.midica.org/

Mozilla Public License 2.0

111 stars 13 forks source link

optimize decompilation #58

Closed truj closed 3 years ago

truj commented 4 years ago

The decompilation process needs some optimizations.

[x] debugging: add quality score for each channel
[x] organize decompilation configuration window with tabs
[x] add decompilation options for using triplets and/or dotted notes / rests
[x] check statistics calculations (I guess it's buggy.)
[x] adjust decompile configuration defaults
[x] avoid unnecessary instrument switches, if the according instrument is never used to play any notes
[x] add more information to explain the decompile options
[x] replace tab-separation by space-separation
[x] fix problems with orphaned inline syllables (currently their placement is incorrect)

EDIT:

[x] rename orphaned syllable modes (e.g. inline => inline_block, block => slice_begin_block)
[x] new karaoke options: "Regard all syllables as orphaned", "Ignore Karaoke completely"
[x] new tab for control change settings

EDIT:

[ ] fix problems after adjusting the decompile config defaults, that appear in some cases

truj commented 4 years ago

After changing the config defaults I found problems in a song. These can be boiled down to the following examples:

INSTRUMENTS
    0    PERCUSSIVE_ORGAN       PERCUSSIVE_ORGAN
END

0  c    /4 d=100%
0  d,b  /4
0  b    /4

* tempo   95

INSTRUMENTS
    0    PERCUSSIVE_ORGAN       PERCUSSIVE_ORGAN
END

0 -     /4
0  c    /4 d=100%
0  d,b  /4
0  b    /4

* tempo   95

They cause different errors. Maybe caused by the same problem, maybe not. Find the problem and fix it.

truj commented 3 years ago

Found the reason for https://github.com/truj/midica/issues/58#issuecomment-683308440. The Note-OFF tick is moved in order to be able to integrate the note into a chord. However, it has been moved to the tick of the next Note-ON of the same note. This caused an exception later because the ON tick is still in the note history but not in the ON/OFF history.

Tried to auto-correct similar issues by moving all conflicting ONs and OFFs to the same direction, without losing any of them. This avoided exceptions. However it makes the whole decompilation process much more complicated and less reliable. And the MIDI output is still not correct.

So I'll stick with the following workaround:

Check if there are conflicts.
In this case: Create a warning and don't move the OFF tick at all So in this rare case, we have an output like this:
```
0  c    /4
0  d    /4 m
0  b    /4
0  b    /4
```