trulia / hologram

A markdown based documentation system for style guides.
http://trulia.github.io/hologram
Other
2.16k stars 199 forks source link

Optional config setting for including additional file extensions #205

Closed itsachen closed 9 years ago

itsachen commented 9 years ago

Adding functionality somewhat requested in #196.

We've been using Hologram and are pleased with how extensible it is. We've written a custom renderer that parses Ruby files, but DocParser's supported file extensions are hard-coded in a constant. So far we've been monkey patching .rb into the array to get by. These changes allow additional file extensions to be included in the parse through a config setting.

Summary of change:

Renamed SUPPORTED_EXTENSIONS to DEFAULT_SUPPORTED_EXTENSIONS. The array of supported extensions is built in DocParser's initialization.

itsachen commented 9 years ago

Sounds good! Any updates on the PR's effects on your existing guides?