search

trulia / hologram

A markdown based documentation system for style guides.
http://trulia.github.io/hologram
Other
2.16k stars 199 forks source link

gem rouge warning Lexers::SHELL #240

Open newtonianb opened 9 years ago

newtonianb commented 9 years ago

We are on Windows 8.1 Ruby 2.1 x64.

We followed the installation procedure but whenever we run hologram we get these gem warnings, what are those can we ignore them?

C:/DevZone/Ruby21-x64/lib/ruby/gems/2.1.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:20: warning: already initialized constant Rouge::Lexers::Shell::KEYWORDS
C:/DevZone/Ruby21-x64/lib/ruby/gems/2.1.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:20: warning: previous definition of KEYWORDS was here
C:/DevZone/Ruby21-x64/lib/ruby/gems/2.1.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:25: warning: already initialized constant Rouge::Lexers::Shell::BUILTINS
C:/DevZone/Ruby21-x64/lib/ruby/gems/2.1.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:25: warning: previous definition of BUILTINS was here
Created the following files and directories:
  hologram_config.yml
  doc_assets/
  doc_assets/_header.html
  doc_assets/_footer.html
  code_example_templates/
  code_example_templates/markdown_example_template.html.erb
  code_example_templates/markdown_table_template.html.erb
  code_example_templates/js_example_template.html.erb
  code_example_templates/jsx_example_template.html.erb
RickMeijer commented 9 years ago

Not really a solution, but downgrading to 1.9.0 seems to help on my end.

xi commented 9 years ago

I have the same issue on linux with ruby 2.1.5. It shows up with rouge 1.9.0, but not with rouge 1.8.0. I could not find any relevant changes in the upstream changelog. So do you think this is an upstream bug or is it in hologram?

jdcantrell commented 9 years ago

I'll have to test this on windows and see. On linux and osx I'm not getting this warnings with Rouge 1.9.1

tonifisler commented 9 years ago

Having the issue here on OS X.

/Library/Ruby/Gems/2.0.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:20: warning: already initialized constant Rouge::Lexers::Shell::KEYWORDS
/Library/Ruby/Gems/2.0.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:20: warning: previous definition of KEYWORDS was here
/Library/Ruby/Gems/2.0.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:25: warning: already initialized constant Rouge::Lexers::Shell::BUILTINS
/Library/Ruby/Gems/2.0.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:25: warning: previous definition of BUILTINS was here
craigcoles commented 9 years ago

@tonifisler These are the exact same warnings that I have also

xi commented 9 years ago

On linux and osx I'm not getting this warnings with Rouge 1.9.1

I still get the warnings with Rouge 1.9.1 on linux. I would be happy to supply additional information if you tell me what you need.

micahgodbolt commented 9 years ago

Can confirm that downgrading to 1.9.0 fixes the issue.

yoon commented 9 years ago

See https://github.com/jneen/rouge/issues/296 and https://github.com/JoshCheek/what-we-ve-got-here-is-an-error-to-communicate/blob/3886aa779a0e6c2d3004a8603fa5daf82a63e018/what_weve_got_here_is_an_error_to_communicate.gemspec#L13

xi commented 9 years ago

Upstream issue is tracked in https://github.com/jneen/rouge/issues/296

edwardsdesign commented 9 years ago

I can also confirm that downgrading to rouge 1.9.0 fixes the issue