updated the react render, to use reactDOM.render

trulia / hologram

A markdown based documentation system for style guides.

http://trulia.github.io/hologram

Other

2.16k stars 200 forks source link

updated the react render, to use reactDOM.render #263

Open sbrady opened 8 years ago

jdcantrell commented 8 years ago

Nice! Do you think it'd be helpful to also change <script type=\"text/jsx\" to <script type=\"text/babel\">? I started to make this change a week ago and then got distracted.

sbrady commented 8 years ago

yes I think so, I'll do that.

I am not sure why the Travis build failed

sbrady commented 8 years ago

Seems like this might be a little tricky, see: https://github.com/Daniel15/babel-standalone/issues/15

Although version 5 still supports in browser transformations. <script src="https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.23/browser.min.js"></script> should we document this somewhere?