Fix bug #279 spreads are not properties.

trullock / NUglify

NUglify is a HTML, JavaScript and CSS minification Library for .NET (fork of AjaxMin + new features)

Other

398 stars 79 forks source link

Fix bug #279 spreads are not properties. #341

Closed nickl- closed 2 years ago

nickl- commented 2 years ago

Fix bug #279 spreads are not properties.

The bug is back because we were only checking for CallExpressions, if you add two Conditionals it will fail again. It should be enough to disregard rests and spreads all together, they shouldn't actually be in the properties list anyway. This fixes the bug, test data modified to reproduce, with no new tests failing so we have to assume it is good.

nJoy

trullock commented 2 years ago

Looks legit

Will test it later and hopefully merge

Thanks for the PR!

nickl- commented 2 years ago

@trullock any chance of looking at this soon?

What are the odds of getting a new release downstream to BuildBundlerMinifier?

nickl- commented 2 years ago

Awesome! Thanx stax for the release.