search

trullock / NUglify

NUglify is a HTML, JavaScript and CSS minification Library for .NET (fork of AjaxMin + new features)
Other
398 stars 79 forks source link

Fix issue 345 #347

Closed zhangyiatmicrosoft closed 1 year ago

zhangyiatmicrosoft commented 1 year ago

345 run-time error JS1292: Strict-mode does not allow duplicate property names

Cannot find any doc regarding how to run tests or add news. I'd be happy to add them!

trullock commented 1 year ago

To add a test add a method to https://github.com/trullock/NUglify/blob/master/src/NUglify.Tests/JavaScript/Bugs.cs and then create the input and expected files under https://github.com/trullock/NUglify/tree/master/src/NUglify.Tests/TestData/JS

trullock commented 1 year ago

👍 will review asap

zhangyiatmicrosoft commented 1 year ago

Can you revert all of the whitespace changes youve made please

I assume you prefer spaces, not TABs? Checked carefully line 3369, and 3373 to 3380 had TABs before my change. Anyhow, I changed them all to spaces.

trullock commented 1 year ago

Unfortunately the codebase has a mix, I inherited it. Your commits had changed a bunch of whitespace on lines that were otherwise untouched, that was my issue which you've now fixed. It made the diff hard to read. Are you done now? I'll review test and merge

zhangyiatmicrosoft commented 1 year ago

Unfortunately the codebase has a mix, I inherited it. Your commits had changed a bunch of whitespace on lines that were otherwise untouched, that was my issue which you've now fixed. It made the diff hard to read. Are you done now? I'll review test and merge

Yes please review. I think at least that segment is easier to read and more consistent now

zhangyiatmicrosoft commented 1 year ago

@trullock any updates