search

trullock / NUglify

NUglify is a HTML, JavaScript and CSS minification Library for .NET (fork of AjaxMin + new features)
Other
396 stars 79 forks source link

[CSS] Handle custom identifiers. #397

Closed akuegel closed 5 months ago

akuegel commented 5 months ago

We can have css like this:

    grid-template-columns: [first-column] 15% [second-column] 10% [third-column] auto;

Currently this runs in an error in CssParser. This PR makes the parser handle these custom identifiers.

akuegel commented 5 months ago

@trullock hope this change of the parser is ok. I ran all the css tests, and they pass.

In VS 2022 I have to install NUnit3TestAdapter package to make it run the NUnit tests. Does it work in older versions of VS without the package? Would it cause problems if that package is added to the Nuglify.Tests project? I can certainly work with this small local change, but I guess it would possibly also make it easier for other contributors if it works "out of the box".

trullock commented 5 months ago

We just updated to nunit 4.6, so the nunit3testadaptor dependency was removed, are you saying its needed for 4.6?

akuegel commented 5 months ago

We just updated to nunit 4.6, so the nunit3testadaptor dependency was removed, are you saying its needed for 4.6?

I did update my fork, so should have fetched nunit 4.6, but still needed nunittestadaptor.

trullock commented 5 months ago

Ok add the dep back

akuegel commented 5 months ago

Ok add the dep back

Thank you, done.

trullock commented 5 months ago

Looks good, will merge now and get released asap

akuegel commented 5 months ago

Thank you very much :)