trulyspinach / SMCAMDProcessor

Power management, monitoring and VirtualSMC plugin for AMD processors
BSD 3-Clause "New" or "Revised" License
1.04k stars 90 forks source link

SMC keys for iStat and MacFanControl #10

Open trulyspinach opened 4 years ago

trulyspinach commented 4 years ago

I'm having a hard time figuring out the combinations of SMC keys required for iStat to display a type of sensor. So some sensors might not be available based on your SMBios type.

For example, if both KeyPCPT and KeyPCTR are enabled power sensor would show up but CPU Proximity disappears at the same time.

Any suggests are welcomed.

radianttap commented 4 years ago

Have you seen this file, from VirtualSMC repo?

It specifically addresses iStat support.

trulyspinach commented 4 years ago

@radianttap I have tried to register only combination of keys listed for a SMBios type in the file you've mentioned but still no luck.

Murmur2k commented 4 years ago

Works well on TG Pro.. thanks! Any plans to break it down by cores (if that's even possible) or expose fan controls?

trulyspinach commented 4 years ago

@Murmur2k i don’t think per core temperatures are possible due the AMD lack of those sensors(as far as I know). Yes, there are plans for adding fan control. But not in any priority.

Murmur2k commented 4 years ago

@trulyspinach yes, sorry I think you are right on the per core sensor temperatures. Really appreciate your work here, I'm after the holy grail of CPU (3900X) temp, fan control access and GPU temps (haven't been able to get this working on Radeon VII).. let me know if I can assist with testing or if you have a beer pot!

trulyspinach commented 4 years ago

@Murmur2k I believe iStat can show GPU temperature and power? At least it is working for my RX580. I have no plan for adding GPU reading as this project is focused on AMD CPU. You are more than welcomed to join the testing, tho. as a new release is coming soon :)

Murmur2k commented 4 years ago

@trulyspinach I've just updated to the latest version and I just wanted to thank you again - amazing work. By the way, is it intentional that the CPU proximity temperature is exposed twice for example in TG Pro? It could be TG Pro at fault here of course.

Screenshot 2020-03-21 at 14 13 21

trulyspinach commented 4 years ago

@Murmur2k I really have no idea. How different third party tool using SMC keys is very odd. So I'm hoping someone with better knowledge would help me here.

Shaneee commented 4 years ago

I also have this. What portion of SMCAMDProcessor deals with this? I think the issue is with VirtualSMC actually. When using FakeSMC and the AMD CPU sensor kext it was displayed correctly. Maybe check the source of that and compare.

Screenshot 2020-03-21 22 57 26

trulyspinach commented 4 years ago

Should not be VirtualSMC's issue, all it does is present registered keys to applications. It is mostly how different applications interpret them as I believe there isn't any official documentation from Apple states SMC keys of each model.

kode54 commented 4 years ago

Minor issue, since you say this is entirely dependent on SMBIOS as well. I had working CPU sensor in the current release when I had an iMacPro1,1 SMBIOS, but now I'm on MacPro7,1, and it no longer has a working CPU sensor.

prawler74 commented 4 years ago

Hi

Thanx for tall the work you put into this. I would really like to have fan control integrated. Is it possible?

Keep up the good work

Best regards Bjørn

trulyspinach commented 4 years ago

@prawler74 definitely possible.

prawler74 commented 4 years ago

That would be awesome. Have you been looking into it?

Is there a way for a noob like me to do this? Though i would rather have you implent it on the gadget.

Bjørn

trulyspinach commented 4 years ago

@prawler74 I believe I have mentioned somewhere previously that I got the code working on my motherboard. However it is just some experiment. It will take more time to make a working application. I do still interested in making one but currently not have much time on it.

It wasn't hard at all, there're a lot of open source implementation out there that you can look for reference.

prawler74 commented 4 years ago

Hi

Yes. You have mentioned it. I will give it a go. Cant wait for you’re comning updates.

Best regards Bjørn

aluveitie commented 4 years ago

@trulyspinach Could you push your experiment on a branch? Might be a good starting point for people wanting to get into it.

Murmur2k commented 4 years ago

@trulyspinach Could you push your experiment on a branch? Might be a good starting point for people wanting to get into it.

That would be awesome and may even work for some with the same controller.

trulyspinach commented 4 years ago

Unfortunately they're gone. It was just a couple lines of code added to some random function.

But if you want some starting point I am sure this will be inspiring :)

nguyennghia9222 commented 4 years ago

I have something new. I loaded SMCSuperIO after CPUPowerManagement and TG Pro shown my fans

Screen Shot 2020-05-15 at 16 46 41
Murmur2k commented 4 years ago

I have something new. I loaded SMCSuperIO after CPUPowerManagement and TG Pro shown my fans

Screen Shot 2020-05-15 at 16 46 41

Amazing - does it allow you to control the fans?

nguyennghia9222 commented 4 years ago

I cannot control fan speed manually via TG Pro. I did some fan setups but nothing effected :)

PSzczepanski1996 commented 2 years ago

Minor issue, since you say this is entirely dependent on SMBIOS as well. I had working CPU sensor in the current release when I had an iMacPro1,1 SMBIOS, but now I'm on MacPro7,1, and it no longer has a working CPU sensor.

@kode54 I can confirm that on r5 3600 and rx5700 XT.

kode54 commented 2 years ago

Unsubscribing, as I no longer run any Hackintosh systems.