search

trulyspinach / SMCAMDProcessor

Power management, monitoring and VirtualSMC plugin for AMD processors
BSD 3-Clause "New" or "Revised" License
1.04k stars 90 forks source link

Cosmetic enhancement #110

Open qumuq-til opened 3 years ago

qumuq-til commented 3 years ago

For the cores graph with blue/red bars it would be cool to have topmost horizontal strips fade in/out from 0 to 100 if partially filled instead of how it is right now. Right now it appears the bar behind is smooth but simply obscured by the grille so the strip itself is 6px high but can be just 1px if not filled completely.

trulyspinach commented 3 years ago

Thanks for the feedback! I thought of that before and in fact that is what the original idea was. However the implementation is a different story: currently the bars was rendered as dotted lines. Fading will require rendering them as separate rects which would introduce more performance overhead, and also harder to code. So I've decided to leave it that way :)

qumuq-til commented 3 years ago

I see. Well, I wouldn't personally worry so much about overhead given that Ryzens are quite performant and the bar window can be easily closed, but maintaining the codebase may indeed be harder. Maybe you'll find some other simpler way, like keeping the grille and the original smooth bar but applying blur and a step-sliding mask above the blue part to prevent blur spillover, instead of fading every block programmatically. Just throwing ideas around, I really don't know much about Cocoa.