Not Publishing CPU Temperature Readings on OC 0.8.9

horus1963 commented 1 year ago

After upgrading from OC 0.8.8 to 0.8.9 SMCAMDProcessor no longer publishers CPU temperature to iStats. Reverting back to OC 0.8.8 restores the readout. I have tried all versions of the kext from 0.6.6 until 0.7.1 in OC 0.8.9 with the same result. Just as a note my OC 0.8.8 setup only works with version 0.6.6

trulyspinach commented 1 year ago

Hi, thanks for reporting the issue. It might be caused by some changes in virtualsmc. Since I’m heavily relying on the UI from power gadgets I don’t think I will be updating the SMC reporting for a while. We need someone to look into what changes need to be made to SMCAMDProcessor to fix this issue.

horus1963 commented 1 year ago

Thanks for your reply. I appreciate that you are busy. I wish I knew how to code so I can help. I hope someone can help out. As for VirtualSMC, it has not changed since last July so it must be something else in OC 0.8.9 that is causing it. Again than you very much for your work. It is greatly appreciated.

horus1963 commented 1 year ago

By the way, as quick update. I updated to OC 0.9.0 and there was no change I could not get CPU temps to show in any monitoring app. On a whim, I decided to try a version older than 0.6.6 of SMCAMDProcessor and low and behold, version 0.6.3 worked for me! 😀 Now I am on OC 0.9.0, Version 0.7.1 of the gadget and power kexts but 0.6.3 for the smc kext and everything is working. Just wanted to give you a heads up.

ChgygLin commented 1 year ago

I have submit a PR to fix the issue. Test fine in the OC 0.9.3. https://github.com/trulyspinach/SMCAMDProcessor/pull/167/commits/079cf0c2fc8052728c85c24e6c84cee29577e7c6

ChgygLin commented 1 year ago

https://github.com/ChgygLin/SMCAMDProcessor/releases/download/v0.7.1/SMCAMDProcessor.kext.zip

I have submit a PR to fix the issue. Test fine in the OC 0.9.3. 079cf0c

arjunmehta commented 11 months ago

@trulyspinach Any updates on this one? If @ChgygLin's fix works, could it be merged?

Kaijun commented 11 months ago

I have submit a PR to fix the issue. Test fine in the OC 0.9.3. 079cf0c

Hey there, I'm just curious about what this means and why it could be resolved. I didn't notice any connections with this problem.

trulyspinach commented 11 months ago

@trulyspinach Any updates on this one? If @ChgygLin's fix works, could it be merged?

I am unable to test this unfortunately. If someone else can help check please let me know.

arjunmehta commented 11 months ago

@trulyspinach Is there somewhere I can find build instructions? I can try testing on my build to verify the fix works.

trulyspinach commented 10 months ago

Hi @arjunmehta

I've just setup a CD so you can access the build here: https://github.com/trulyspinach/SMCAMDProcessor/actions/runs/6313175833

Just download the artifacts.

ChgygLin commented 10 months ago

I have submit a PR to fix the issue. Test fine in the OC 0.9.3. 079cf0c

Hey there, I'm just curious about what this means and why it could be resolved. I didn't notice any connections with this problem.

Hi, @Kaijun, I explained it in here. Welcome to discuss ^_^

arjunmehta commented 10 months ago

Hi there, I tested the build and CPU temp now seems to be showing as expected! iStat Menus is now correctly showing "CPU Proximity" reading which matches the AMD Power Gadget reading.

Separate issue

Only mentioning here because it is adjacently related. GPU Reading is oddly missing from iStats "Sensors" widget but shows in the "CPU & GPU" usage widget, but I think that is a separate issue.

arjunmehta commented 10 months ago

@trulyspinach @ChgygLin

I have been using the new kexts for a while and may be seeing some higher than expected power consumption in the system, for both idle and load. My power supply turned off for the first time ever while doing some heavy work (GPU + CPU). This may just be a coincidence however.

Going to run a few tests with the older version to see if I can replicate.

arjunmehta commented 10 months ago

I was able to replicate the power supply shut down with the old kext, so it's not a regression AFAIK.

I will continue to test to make sure everything is operating the same.

trulyspinach commented 10 months ago

Hi there, I tested the build and CPU temp now seems to be showing as expected! iStat Menus is now correctly showing "CPU Proximity" reading which matches the AMD Power Gadget reading.

Separate issue

Only mentioning here because it is adjacently related. GPU Reading is oddly missing from iStats "Sensors" widget but shows in the "CPU & GPU" usage widget, but I think that is a separate issue.

Thank you @arjunmehta, that's good to know.

trulyspinach commented 10 months ago

@trulyspinach @ChgygLin

I have been using the new kexts for a while and may be seeing some higher than expected power consumption in the system, for both idle and load. My power supply turned off for the first time ever while doing some heavy work (GPU + CPU). This may just be a coincidence however.

Going to run a few tests with the older version to see if I can replicate.

I don't think there has been any changes in the way we read power consumption in a while, so it's likely that the power consumption in your system is increased but because of some other factors. Hope that you will be able to find out what happened.

ChgygLin commented 10 months ago

Hi there, I tested the build and CPU temp now seems to be showing as expected! iStat Menus is now correctly showing "CPU Proximity" reading which matches the AMD Power Gadget reading.

Separate issue

Only mentioning here because it is adjacently related. GPU Reading is oddly missing from iStats "Sensors" widget but shows in the "CPU & GPU" usage widget, but I think that is a separate issue.

That's great! ^_^

trulyspinach commented 10 months ago

Awesome, ill close this issue now!

trulyspinach / SMCAMDProcessor