search

trulyspinach / SMCAMDProcessor

Power management, monitoring and VirtualSMC plugin for AMD processors
BSD 3-Clause "New" or "Revised" License
1.04k stars 90 forks source link

Selectable powerplan #55

Closed aluveitie closed 4 years ago

aluveitie commented 4 years ago

I tried to make my less aggressive speed adjustment optionally selectable.

@trulyspinach may I ask you for your opinion?

trulyspinach commented 4 years ago

Thanks a lot for your contribution. However I have decided to not merge this.

The popup button was originally designed to adjust the refresh rate of the CPU frequency graph right under it. Plus, OS should never have an option to ask user how to adjust CPU frequency, it is their job to control hardware correctly. "Power Plan" is not for that.

The root problem is the current method of detecting CPU demand is not sensitive enough, XCPM certainly done a way better job than this. However I don't have enough time to fully reverse engineer it(as there's no source code available) nor come up with a better implementation. I will leave those parameters as is(very sensitive) in master branch until better implementations are available.

aluveitie commented 4 years ago

@trulyspinach Understandably, thanks for your elaborations. I'll close the pull request then.