trulyspinach / SMCAMDProcessor

Power management, monitoring and VirtualSMC plugin for AMD processors
BSD 3-Clause "New" or "Revised" License
1.06k stars 90 forks source link

Simplifies graph view #64

Closed aluveitie closed 4 years ago

aluveitie commented 4 years ago

While working on multiple lines per graph the sortedDataPoints made things unnecessary complicated. It also leads to lines going out of the graph after running for some time in a narrow band.

The new implementation has a few advantages:

before: Screenshot 2020-05-15 at 10 20 00

after: Screenshot 2020-05-15 at 09 49 08

trulyspinach commented 4 years ago

Hi @aluveitie still thanks for the contribute. If you check back to previous submission you can see that the logic is similar. All lines are evenly spaced. I have again intentionally made it spaced sort of randomized.

I am awared of the overflowing bug tho, but was too lazy to apply a fix.

aluveitie commented 4 years ago

I can update it to be also spaced out a little 'randomized'

aluveitie commented 4 years ago

How's this?

It's more consistent across all three graphs :)

Screenshot 2020-05-15 at 10 54 44

aluveitie commented 4 years ago

@trulyspinach My last commit made it unevenly spaced, more like the previous solution. I agree this way it looks much nicer than the evenly spaced graphs.

Since frequency, temperature and power are always within a limited/fixed range I think the min/max approach is a fitting solution and much simpler to extend later.