trumank / mint

Deep Rock Galactic mod loader and integration
MIT License
179 stars 24 forks source link

More robust handling of invalid config #197

Open jieyouxu opened 2 weeks ago

jieyouxu commented 2 weeks ago

If we fail to deserialize config or whatever, we want to fail hard but with better diagnostics:

In particular the configs being generation by the same version of mint does not guarantee it can be successfully deserialized, given that it's possible for the configs to be corrupted for reasons such as:

jieyouxu commented 2 weeks ago

Hmm this might also have to do with how we do the config serialization logic. The current temp-file-and-rename logic is atomic on Linux, but is not guaranteed atomic on Windows in presence of an existing config file.