search

trumbitta / nx-trumbitta

💡An attempt to start collecting all of my Nx-related Open Source work in a mono-repo.
MIT License
47 stars 11 forks source link

fix(openapi-generator-cli): use correct format for additionalProperties #23

Closed dapperdandev closed 3 years ago

dapperdandev commented 3 years ago

Per the documentation: https://openapi-generator.tech/docs/usage#additional-properties

--additional-properties=prependFormOrBodyParameters=true

trumbitta commented 3 years ago

Hey, this one I wasn't able to reproduce. I used the modelPropertyNaming additional property and it worked both with the original and your PR.

I tried with a dedicated e2e test, and manually via terminal in interactive mode. I wasn't able to try it via Nx console because #26 .

Could it be another issue with the original childProcess.spawn()?
If yes, did you have the issue on Windows? And maybe it will go away once I merge #22 ?

dapperdandev commented 3 years ago

@trumbitta I'm fine with waiting to see if #22 fixes it. I was having issues on Windows and noticed the slight difference in the openapi-generator-cli docs. That said, I've definitely seen it done both ways.

trumbitta commented 3 years ago

@djbreen7 I just published 1.3.1 with your fix 🚀 for Windows.

Can you please check if you are able to use the additional properties you need on Windows with this version?

Also, do you have a twitter handle you'd like me to add to the release announcement and to the CONTRIBUTORS/CONTRIBUTING file once I get to work on #25 ? 😄

dapperdandev commented 3 years ago

@trumbitta Yeah, this seems to work fine now with the original code. Closing.

I'm @dapperdandev on twitter. My profile is pretty barebones. Deleted it then recreated it. Thanks!