search

trumbitta / nx-trumbitta

💡An attempt to start collecting all of my Nx-related Open Source work in a mono-repo.
MIT License
47 stars 11 forks source link

Do not mark @types/X as unused if X is used #59

Closed joeflateau closed 2 years ago

joeflateau commented 2 years ago

Title says it all, @types/express should not be flagged as unused when express is used

trumbitta commented 2 years ago

Hey Joe 🎸 🎶

Is this about nx-plugin-unused-deps? 🤔 Good catch! I would expect all of the @types packages to always end up flagged as unused because the dependency graph can't find them directly imported anywhere. 💡

It should be a fun a little edge case to work on for a contributor. Maybe you are interested? 😺

I'll add the proper label for now. I'm not sure when I'll be able to work on it myself.

joeflateau commented 2 years ago

yes! for unused-deps. I can take a stab at it 😀

trumbitta commented 2 years ago

Hey @all-contributors please add @joeflateau for his bug contributions.

allcontributors[bot] commented 2 years ago

@trumbitta

I've put up a pull request to add @joeflateau! :tada: