trumbitta / nx-trumbitta

💡An attempt to start collecting all of my Nx-related Open Source work in a mono-repo.

MIT License

47 stars 11 forks source link

fix: unused-deps should consider @types/X to be used if X is used #61

Closed joeflateau closed 2 years ago

joeflateau commented 2 years ago

fixes #59

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d17cb6d7418c105e649e6bc29cfda2c11a2b7167. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 2 targets

- [`nx affected:e2e --base=remotes/origin/main`](https://nx.app/runs/KhBEdeeJNwa) - [`nx affected:test --base=remotes/origin/main`](https://nx.app/runs/bG08bp37fy1)

Sent with 💌 from NxCloud.

joeflateau commented 2 years ago

@trumbitta unfortunately i've hit a bit of a roadblock in that the project graph that e2e tests generate seems to be the project graph of this project rather than the test/temp project. any tips on how to make sure it generates the graph of the actual test project?

joeflateau commented 2 years ago

actually I found a way, you have to pack the dist folder and install from that pack instead of from file: because file: creates symlinks and breaks how nx finds the dep graph