Closed youngchen7 closed 2 years ago
CI is running/has finished running commands for commit b1ec65cbb5033c851c0db27029dc20836295bdb1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
π See all runs for this branch
Sent with π from NxCloud.
π Hey @youngchen7, π Thank you! This is an awesome contribution!
π Before I take it for a spin, and most certainly merge it, would you mind also adding relevant test cases to the unit tests for the executor?
Yup, I'll look into adding unit tests either today or tomorrow!
I've added the unit tests. It's a little odd to mock / expect from a logger, but I didn't see another good way to validate that the output was being forwarded.
Originally I wanted to add a unit test that would validate the fix for the child buffer size causing process hangs, but that's a spawn implementation specific issue and not possible to test, I think.
closing in favor of #72!
Log the command and arguments passed to
openapi-generator-cli
Add a handler to stdout for the spawned child process, and log data using the nx devkit logger.
Add
silent
option to suppress outputdocs: add joeflateau as a contributor for doc