trumbitta / nx-trumbitta

πŸ’‘An attempt to start collecting all of my Nx-related Open Source work in a mono-repo.
MIT License
47 stars 11 forks source link

Pipe through logs from the spawned openapi generator process #71

Closed youngchen7 closed 2 years ago

youngchen7 commented 2 years ago

Log the command and arguments passed to openapi-generator-cli

Add a handler to stdout for the spawned child process, and log data using the nx devkit logger.

Add silent option to suppress output

docs: add joeflateau as a contributor for doc

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b1ec65cbb5033c851c0db27029dc20836295bdb1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 2 targets - [`nx affected:e2e --base=remotes/origin/main`](https://nx.app/runs/QrGqsEqCda2) - [`nx affected:test --base=remotes/origin/main`](https://nx.app/runs/zKGmlNK1S2p)

Sent with πŸ’Œ from NxCloud.

trumbitta commented 2 years ago

πŸ‘‹ Hey @youngchen7, πŸš€ Thank you! This is an awesome contribution!

πŸ™ Before I take it for a spin, and most certainly merge it, would you mind also adding relevant test cases to the unit tests for the executor?

youngchen7 commented 2 years ago

Yup, I'll look into adding unit tests either today or tomorrow!

youngchen7 commented 2 years ago

I've added the unit tests. It's a little odd to mock / expect from a logger, but I didn't see another good way to validate that the output was being forwarded.

Originally I wanted to add a unit test that would validate the fix for the child buffer size causing process hangs, but that's a spawn implementation specific issue and not possible to test, I think.

trumbitta commented 2 years ago

closing in favor of #72!